[Fixbug]: Repository object reference count increase abnormal #328
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For issue #326, Repository object's reference count will be increased abnormally by it's remotes getter function. That is because 'py_args' does not release which hold 1 reference to repository.
This issue stem from my requirement to dealloc repository object for purpose of releasing file descriptor resource occupied by it. When I construct a new repository object, I found that the old one won't be deconstructed since it's reference count can't decrease to zero.