Add OS X installation #468
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've gone with taking a string and converting it because the depth of the namespacing in the libgit2 name is rather large and we don't care about the global namespace that C has; and this also lets us pass the same as the '-X' option to git-merge.
Broken with previous commits :)
This should make it work both for users and developers.
It is not possible to know how we can free the results of this allocation, so we shouldn't be using this function. We have a convention of returning Oid objects in pygit2, so let's keep to that in these places.
I think that is best to have that explicitly set there (and it should possibly be updated in Pypi too). Thanks for this lib! Cordially Philippe
This lets us look up remotes by name, which is not possible by just returning the list of remotes. Move remote creation to Repostiory.remotes.create() and keep the old Repository.create_remote() for compatibility, delegating to this new way. Existing code should keep working, but this moves us towards what we'd need for a better interface in 0.22 which makes remote renaming and deleting work with a name rather than an instance and would make sense to exist as part of an Remote.remotes object.
|
Now we have two competing PRs for adding OS X install notes, this one and #448 Installation instructions should talk just about brew, since installing libgit2 from source or pygit2 with pip is basically like the generic install documentation. Personally I think #448 is closer. If it has not yet been merged is because I understand it has not been updated to take into account the comments from @carlosmn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.