Submodule.open() fix, URL write support #513
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well. As has been initially proposed by @jdavid this PR rewrites the submodule feature I've been implementing in Python with CFFI. Reason has been a problem that I overlooked with the previous implementation, where the repository returned by submodule.open() was not a pygit2.Submodule but of the C SubmoduleType, thus missing some properties/methods. As I found no easy way to properly instantiate the pygit2.Submodule type instead of the C type from C code I just reimplemented that in Python. If there is any obvious way of doing it I may as well do that, if requested.
Some additional functions have been implemented, as well, thus providing URL write support for submodules, their repos and gitmodule entries.