Adds combined wallet guidance #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for lightningdevkit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
jurvis
approved these changes
Nov 15, 2022
| "sock lyrics village put galaxy famous pass act ship second diagram pull" | ||
| ).unwrap(); | ||
| let seed: [u8; 64] = mnemonic.to_seed_normalized(""); | ||
| let master_xprv = ExtendedPrivKey::new_master(Network::Testnet, &seed).unwrap(); |
There was a problem hiding this comment.
might be a little "duh", but should we add a comment here to point out that users should probably swap this out for Mainnet if they wish?
|
ACK 5a60808. I like the "tip" section. 2 small non-blocking nits: (a) the code example uses |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds guidance on how to allow for a single wallet setup using a BIP32 HD wallet + Hardened Child Key when seeding LDK.
Minor TODO:
Preview