Skip to content

Commit af76fac

Browse files
authored
Merge pull request #2065 from TheBlueMatt/2023-02-0.0.114
Cut 0.0.114
2 parents 4d2679f + a361be3 commit af76fac

File tree

12 files changed

+141
-54
lines changed

12 files changed

+141
-54
lines changed

CHANGELOG.md

+114
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,117 @@
1+
# 0.0.114 - Mar 3, 2023 - "Faster Async BOLT12 Retries"
2+
3+
## API Updates
4+
* `InvoicePayer` has been removed and its features moved directly into
5+
`ChannelManager`. As such it now requires a simplified `Router` and supports
6+
`send_payment_with_retry` (and friends). `ChannelManager::retry_payment` was
7+
removed in favor of the automated retries. Invoice payment utilities in
8+
`lightning-invoice` now call the new code (#1812, #1916, #1929, #2007, etc).
9+
* `Sign`/`BaseSign` has been renamed `ChannelSigner`, with `EcdsaChannelSigner`
10+
split out in anticipation of future schnorr/taproot support (#1967).
11+
* The catch-all `KeysInterface` was split into `EntropySource`, `NodeSigner`,
12+
and `SignerProvider`. `KeysManager` implements all three (#1910, #1930).
13+
* `KeysInterface::get_node_secret` is now `KeysManager::get_node_secret_key`
14+
and is no longer required for external signers (#1951, #2070).
15+
* A `lightning-transaction-sync` crate has been added which implements keeping
16+
LDK in sync with the chain via an esplora server (#1870). Note that it can
17+
only be used on nodes that *never* ran a previous version of LDK.
18+
* `Score` is updated in `BackgroundProcessor` instead of via `Router` (#1996).
19+
* `ChainAccess::get_utxo` (now `UtxoAccess`) can now be resolved async (#1980).
20+
* BOLT12 `Offer`, `InvoiceRequest`, `Invoice` and `Refund` structs as well as
21+
associated builders have been added. Such invoices cannot yet be paid due to
22+
missing support for blinded path payments (#1927, #1908, #1926).
23+
* A `lightning-custom-message` crate has been added to make combining multiple
24+
custom messages into one enum/handler easier (#1832).
25+
* `Event::PaymentPathFailure` is now generated for failure to send an HTLC
26+
over the first hop on our local channel (#2014, #2043).
27+
* `lightning-net-tokio` no longer requires an `Arc` on `PeerManager` (#1968).
28+
* `ChannelManager::list_recent_payments` was added (#1873).
29+
* `lightning-background-processor` `std` is now optional in async mode (#1962).
30+
* `create_phantom_invoice` can now be used in `no-std` (#1985).
31+
* The required final CLTV delta on inbound payments is now configurable (#1878)
32+
* bitcoind RPC error code and message are now surfaced in `block-sync` (#2057).
33+
* Get `historical_estimated_channel_liquidity_probabilities` was added (#1961).
34+
* `ChannelManager::fail_htlc_backwards_with_reason` was added (#1948).
35+
* Macros which implement serialization using TLVs or straight writing of struct
36+
fields are now public (#1823, #1976, #1977).
37+
38+
## Backwards Compatibility
39+
* Any inbound payments with a custom final CLTV delta will be rejected by LDK
40+
if you downgrade prior to receipt (#1878).
41+
* `Event::PaymentPathFailed::network_update` will always be `None` if an
42+
0.0.114-generated event is read by a prior version of LDK (#2043).
43+
* `Event::PaymentPathFailed::all_paths_removed` will always be false if an
44+
0.0.114-generated event is read by a prior version of LDK. Users who rely on
45+
it to determine payment retries should migrate to `Event::PaymentFailed`, in
46+
a separate release prior to upgrading to LDK 0.0.114 if downgrading is
47+
supported (#2043).
48+
49+
## Performance Improvements
50+
* Channel data is now stored per-peer and channel updates across multiple
51+
peers can be operated on simultaneously (#1507).
52+
* Routefinding is roughly 1.5x faster (#1799).
53+
* Deserializing a `NetworkGraph` is roughly 6x faster (#2016).
54+
* Memory usage for a `NetworkGraph` has been reduced substantially (#2040).
55+
* `KeysInterface::get_secure_random_bytes` is roughly 200x faster (#1974).
56+
57+
## Bug Fixes
58+
* Fixed a bug where a delay in processing a `PaymentSent` event longer than the
59+
time taken to persist a `ChannelMonitor` update, when occurring immediately
60+
prior to a crash, may result in the `PaymentSent` event being lost (#2048).
61+
* Fixed spurious rejections of rapid gossip sync data when the graph has been
62+
updated by other means between gossip syncs (#2046).
63+
* Fixed a panic in `KeysManager` when the high bit of `starting_time_nanos`
64+
is set (#1935).
65+
* Resolved an issue where the `ChannelManager::get_persistable_update_future`
66+
future would fail to wake until a second notification occurs (#2064).
67+
* Resolved a memory leak when using `ChannelManager::send_probe` (#2037).
68+
* Fixed a deadlock on some platforms at least when using async `ChannelMonitor`
69+
updating (#2006).
70+
* Removed debug-only assertions which were reachable in threaded code (#1964).
71+
* In some cases when payment sending fails on our local channel retries no
72+
longer take the same path and thus never succeed (#2014).
73+
* Retries for spontaneous payments have been fixed (#2002).
74+
* Return an `Err` if `lightning-persister` fails to read the directory listing
75+
rather than panicing (#1943).
76+
* `peer_disconnected` will now never be called without `peer_connected` (#2035)
77+
78+
## Security
79+
0.0.114 fixes several denial-of-service vulnerabilities which are reachable from
80+
untrusted input from channel counterparties or in deployments accepting inbound
81+
connections or channels. It also fixes a denial-of-service vulnerability in rare
82+
cases in the route finding logic.
83+
* The number of pending un-funded channels as well as peers without funded
84+
channels is now limited to avoid denial of service (#1988).
85+
* A second `channel_ready` message received immediately after the first could
86+
lead to a spurious panic (#2071). This issue was introduced with 0conf
87+
support in LDK 0.0.107.
88+
* A division-by-zero issue was fixed in the `ProbabilisticScorer` if the amount
89+
being sent (including previous-hop fees) is equal to a channel's capacity
90+
while walking the graph (#2072). The division-by-zero was introduced with
91+
historical data tracking in LDK 0.0.112.
92+
93+
In total, this release features 130 files changed, 21457 insertions, 10113
94+
deletions in 343 commits from 18 authors, in alphabetical order:
95+
* Alec Chen
96+
* Allan Douglas R. de Oliveira
97+
* Andrei
98+
* Arik Sosman
99+
* Daniel Granhão
100+
* Duncan Dean
101+
* Elias Rohrer
102+
* Jeffrey Czyz
103+
* John Cantrell
104+
* Kurtsley
105+
* Matt Corallo
106+
* Max Fang
107+
* Omer Yacine
108+
* Valentine Wallace
109+
* Viktor Tigerström
110+
* Wilmer Paulino
111+
* benthecarman
112+
* jurvis
113+
114+
1115
# 0.0.113 - Dec 16, 2022 - "Big Movement Intercepted"
2116

3117
## API Updates

lightning-background-processor/Cargo.toml

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "lightning-background-processor"
3-
version = "0.0.113"
3+
version = "0.0.114"
44
authors = ["Valentine Wallace <[email protected]>"]
55
license = "MIT OR Apache-2.0"
66
repository = "http://github.com/lightningdevkit/rust-lightning"
@@ -21,11 +21,11 @@ default = ["std"]
2121

2222
[dependencies]
2323
bitcoin = { version = "0.29.0", default-features = false }
24-
lightning = { version = "0.0.113", path = "../lightning", default-features = false }
25-
lightning-rapid-gossip-sync = { version = "0.0.113", path = "../lightning-rapid-gossip-sync", default-features = false }
24+
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
25+
lightning-rapid-gossip-sync = { version = "0.0.114", path = "../lightning-rapid-gossip-sync", default-features = false }
2626
futures-util = { version = "0.3", default-features = false, features = ["async-await-macro"], optional = true }
2727

2828
[dev-dependencies]
29-
lightning = { version = "0.0.113", path = "../lightning", features = ["_test_utils"] }
30-
lightning-invoice = { version = "0.21.0", path = "../lightning-invoice" }
31-
lightning-persister = { version = "0.0.113", path = "../lightning-persister" }
29+
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
30+
lightning-invoice = { version = "0.22.0", path = "../lightning-invoice" }
31+
lightning-persister = { version = "0.0.114", path = "../lightning-persister" }

lightning-block-sync/Cargo.toml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "lightning-block-sync"
3-
version = "0.0.113"
3+
version = "0.0.114"
44
authors = ["Jeffrey Czyz", "Matt Corallo"]
55
license = "MIT OR Apache-2.0"
66
repository = "http://github.com/lightningdevkit/rust-lightning"
@@ -19,13 +19,13 @@ rpc-client = [ "serde", "serde_json", "chunked_transfer" ]
1919

2020
[dependencies]
2121
bitcoin = "0.29.0"
22-
lightning = { version = "0.0.113", path = "../lightning" }
22+
lightning = { version = "0.0.114", path = "../lightning" }
2323
futures-util = { version = "0.3" }
2424
tokio = { version = "1.0", features = [ "io-util", "net", "time" ], optional = true }
2525
serde = { version = "1.0", features = ["derive"], optional = true }
2626
serde_json = { version = "1.0", optional = true }
2727
chunked_transfer = { version = "1.4", optional = true }
2828

2929
[dev-dependencies]
30-
lightning = { version = "0.0.113", path = "../lightning", features = ["_test_utils"] }
30+
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }
3131
tokio = { version = "~1.14", features = [ "macros", "rt" ] }

lightning-custom-message/Cargo.toml

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "lightning-custom-message"
3-
version = "0.0.113"
3+
version = "0.0.114"
44
authors = ["Jeffrey Czyz"]
55
license = "MIT OR Apache-2.0"
66
repository = "http://github.com/lightningdevkit/rust-lightning"
@@ -15,4 +15,4 @@ rustdoc-args = ["--cfg", "docsrs"]
1515

1616
[dependencies]
1717
bitcoin = "0.29.0"
18-
lightning = { version = "0.0.113", path = "../lightning" }
18+
lightning = { version = "0.0.114", path = "../lightning" }

lightning-invoice/Cargo.toml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
[package]
22
name = "lightning-invoice"
33
description = "Data structures to parse and serialize BOLT11 lightning invoices"
4-
version = "0.21.0"
4+
version = "0.22.0"
55
authors = ["Sebastian Geisler <[email protected]>"]
66
documentation = "https://docs.rs/lightning-invoice/"
77
license = "MIT OR Apache-2.0"
@@ -21,14 +21,14 @@ std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]
2121

2222
[dependencies]
2323
bech32 = { version = "0.9.0", default-features = false }
24-
lightning = { version = "0.0.113", path = "../lightning", default-features = false }
24+
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
2525
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
2626
num-traits = { version = "0.2.8", default-features = false }
2727
bitcoin_hashes = { version = "0.11", default-features = false }
2828
hashbrown = { version = "0.8", optional = true }
2929
serde = { version = "1.0.118", optional = true }
3030

3131
[dev-dependencies]
32-
lightning = { version = "0.0.113", path = "../lightning", default-features = false, features = ["_test_utils"] }
32+
lightning = { version = "0.0.114", path = "../lightning", default-features = false, features = ["_test_utils"] }
3333
hex = "0.4"
3434
serde_json = { version = "1"}

lightning-net-tokio/Cargo.toml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "lightning-net-tokio"
3-
version = "0.0.113"
3+
version = "0.0.114"
44
authors = ["Matt Corallo"]
55
license = "MIT OR Apache-2.0"
66
repository = "https://github.com/lightningdevkit/rust-lightning/"
@@ -16,9 +16,9 @@ rustdoc-args = ["--cfg", "docsrs"]
1616

1717
[dependencies]
1818
bitcoin = "0.29.0"
19-
lightning = { version = "0.0.113", path = "../lightning" }
19+
lightning = { version = "0.0.114", path = "../lightning" }
2020
tokio = { version = "1.0", features = [ "io-util", "macros", "rt", "sync", "net", "time" ] }
2121

2222
[dev-dependencies]
2323
tokio = { version = "~1.14", features = [ "io-util", "macros", "rt", "rt-multi-thread", "sync", "net", "time" ] }
24-
lightning = { version = "0.0.113", path = "../lightning", features = ["_test_utils"] }
24+
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }

lightning-persister/Cargo.toml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "lightning-persister"
3-
version = "0.0.113"
3+
version = "0.0.114"
44
authors = ["Valentine Wallace", "Matt Corallo"]
55
license = "MIT OR Apache-2.0"
66
repository = "https://github.com/lightningdevkit/rust-lightning/"
@@ -18,11 +18,11 @@ _bench_unstable = ["lightning/_bench_unstable"]
1818

1919
[dependencies]
2020
bitcoin = "0.29.0"
21-
lightning = { version = "0.0.113", path = "../lightning" }
21+
lightning = { version = "0.0.114", path = "../lightning" }
2222
libc = "0.2"
2323

2424
[target.'cfg(windows)'.dependencies]
2525
winapi = { version = "0.3", features = ["winbase"] }
2626

2727
[dev-dependencies]
28-
lightning = { version = "0.0.113", path = "../lightning", features = ["_test_utils"] }
28+
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }

lightning-rapid-gossip-sync/Cargo.toml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "lightning-rapid-gossip-sync"
3-
version = "0.0.113"
3+
version = "0.0.114"
44
authors = ["Arik Sosman <[email protected]>"]
55
license = "MIT OR Apache-2.0"
66
repository = "https://github.com/lightningdevkit/rust-lightning"
@@ -16,8 +16,8 @@ std = ["lightning/std"]
1616
_bench_unstable = []
1717

1818
[dependencies]
19-
lightning = { version = "0.0.113", path = "../lightning", default-features = false }
19+
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
2020
bitcoin = { version = "0.29.0", default-features = false }
2121

2222
[dev-dependencies]
23-
lightning = { version = "0.0.113", path = "../lightning", features = ["_test_utils"] }
23+
lightning = { version = "0.0.114", path = "../lightning", features = ["_test_utils"] }

lightning-transaction-sync/Cargo.toml

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "lightning-transaction-sync"
3-
version = "0.0.113"
3+
version = "0.0.114"
44
authors = ["Elias Rohrer"]
55
license = "MIT OR Apache-2.0"
66
repository = "http://github.com/lightningdevkit/rust-lightning"
@@ -20,14 +20,14 @@ esplora-blocking = ["esplora-client/blocking"]
2020
async-interface = []
2121

2222
[dependencies]
23-
lightning = { version = "0.0.113", path = "../lightning", default-features = false }
23+
lightning = { version = "0.0.114", path = "../lightning", default-features = false }
2424
bitcoin = { version = "0.29.0", default-features = false }
2525
bdk-macros = "0.6"
2626
futures = { version = "0.3", optional = true }
2727
esplora-client = { version = "0.3.0", default-features = false, optional = true }
2828

2929
[dev-dependencies]
30-
lightning = { version = "0.0.113", path = "../lightning", features = ["std"] }
30+
lightning = { version = "0.0.114", path = "../lightning", features = ["std"] }
3131
electrsd = { version = "0.22.0", features = ["legacy", "esplora_a33e97e1", "bitcoind_23_0"] }
3232
electrum-client = "0.12.0"
3333
once_cell = "1.16.0"

lightning/Cargo.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
[package]
22
name = "lightning"
3-
version = "0.0.113"
3+
version = "0.0.114"
44
authors = ["Matt Corallo"]
55
license = "MIT OR Apache-2.0"
66
repository = "https://github.com/lightningdevkit/rust-lightning/"

pending_changelog/1878.txt

-11
This file was deleted.

pending_changelog/2043.txt

-16
This file was deleted.

0 commit comments

Comments
 (0)