-
Notifications
You must be signed in to change notification settings - Fork 405
Cut 0.0.114 #2065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut 0.0.114 #2065
Conversation
Codecov ReportPatch and project coverage have no change.
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2065 +/- ##
=======================================
Coverage 87.18% 87.18%
=======================================
Files 100 100
Lines 44727 44743 +16
Branches 44727 44743 +16
=======================================
+ Hits 38993 39010 +17
+ Misses 5734 5733 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
CHANGELOG.md
Outdated
* `lightning-background-processor` `std` is now optional in async mode (#1962). | ||
* `create_phantom_invoice` can now be used in `no-std` (#1985). | ||
* The required final CLTV delta on inbound payments is now configurable (#1878) | ||
* `historical_estimated_channel_liquidity_probabilities` was added (#1961) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Its such a trivial thing I didn't want to go over a line for it...Added "Get"
|
||
## Performance Improvements | ||
* Channel data is now stored per-peer and channel updates across multiple | ||
peers can be operated on simultaneously (#1507). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/simultaneously/concurrently/g no ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think they're synonyms here?
0.0.114 fixes a denial-of-service vulnerability which is reachable from | ||
untrusted input in deployments accepting inbound connections or channels. | ||
* The number of pending un-funded channels as well as peer without funded | ||
channels is now limited to avoid denial of service (#1988). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS
, the maximum number of peers we allow to try opening a channel.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to specify the exact amount. There's now a limit.
aa36c3f
to
35bb9bd
Compare
Added notes for things we've merged since 114-beta. |
35bb9bd
to
a3a1f6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs rebase. I think it'd be fine to squash as you go
a3a1f6a
to
42ff2c1
Compare
42ff2c1
to
cb1af87
Compare
LGTM after squash |
cb1af87
to
bdee092
Compare
Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date. |
bdee092
to
ca0f9ce
Compare
ca0f9ce
to
a361be3
Compare
Landed all the dependent PRs, rebased, squashed. Should be good to go. Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073 |
Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.