Skip to content

Cut 0.0.114 #2065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 4, 2023
Merged

Cut 0.0.114 #2065

merged 2 commits into from
Mar 4, 2023

Conversation

TheBlueMatt
Copy link
Collaborator

Still need to land a few things and thus do the commit counters, but would like review on the release notes themselves.

@TheBlueMatt TheBlueMatt added this to the 0.0.114 milestone Mar 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Mar 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fac5373) 87.18% compared to head (a361be3) 87.18%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2065   +/-   ##
=======================================
  Coverage   87.18%   87.18%           
=======================================
  Files         100      100           
  Lines       44727    44743   +16     
  Branches    44727    44743   +16     
=======================================
+ Hits        38993    39010   +17     
+ Misses       5734     5733    -1     
Impacted Files Coverage Δ
lightning/src/util/time.rs 38.29% <0.00%> (-4.56%) ⬇️
lightning/src/ln/features.rs 92.55% <0.00%> (-0.33%) ⬇️
lightning/src/ln/functional_tests.rs 97.21% <0.00%> (ø)
lightning/src/ln/channel.rs 84.02% <0.00%> (+0.01%) ⬆️
lightning/src/ln/priv_short_conf_tests.rs 95.73% <0.00%> (+0.02%) ⬆️
lightning/src/routing/scoring.rs 91.85% <0.00%> (+0.09%) ⬆️
lightning/src/ln/peer_handler.rs 60.86% <0.00%> (+0.16%) ⬆️
lightning/src/ln/outbound_payment.rs 80.77% <0.00%> (+0.16%) ⬆️
lightning/src/chain/onchaintx.rs 86.46% <0.00%> (+0.68%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

CHANGELOG.md Outdated
* `lightning-background-processor` `std` is now optional in async mode (#1962).
* `create_phantom_invoice` can now be used in `no-std` (#1985).
* The required final CLTV delta on inbound payments is now configurable (#1878)
* `historical_estimated_channel_liquidity_probabilities` was added (#1961)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can add a small comment to say what it does "query the historical score bucket of a channel by scid" and say it was added to ProbabilisticScorerUsingTime.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its such a trivial thing I didn't want to go over a line for it...Added "Get"


## Performance Improvements
* Channel data is now stored per-peer and channel updates across multiple
peers can be operated on simultaneously (#1507).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/simultaneously/concurrently/g no ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think they're synonyms here?

0.0.114 fixes a denial-of-service vulnerability which is reachable from
untrusted input in deployments accepting inbound connections or channels.
* The number of pending un-funded channels as well as peer without funded
channels is now limited to avoid denial of service (#1988).
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it mentions MAX_UNFUNDED_CHANNEL_PEERS, the maximum number of peers we allow to try opening a channel.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to specify the exact amount. There's now a limit.

@TheBlueMatt
Copy link
Collaborator Author

Added notes for things we've merged since 114-beta.

Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs rebase. I think it'd be fine to squash as you go

@valentinewallace
Copy link
Contributor

LGTM after squash

@TheBlueMatt
Copy link
Collaborator Author

TheBlueMatt commented Mar 3, 2023

Rebased on the two remaining PRs and squashed, including the diff stats for the release notes and today's date.

@TheBlueMatt
Copy link
Collaborator Author

Landed all the dependent PRs, rebased, squashed. Should be good to go.

Note that the new peer_handler smoke test failed once in CI, I've tried to repro it locally but couldnt. I don't think it blocks release but worth noting: #2073

@TheBlueMatt TheBlueMatt merged commit af76fac into lightningdevkit:main Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants