Skip to content

Generate PaymentPathFailed for MonitorUpdate-sourced HTLC failures when we don't have a corresponding pending payment entry #1102

Closed
@TheBlueMatt

Description

@TheBlueMatt

If a user send_payments, we return (implying we've sent an HTLC and persisted a ChannelMonitor with the HTLCSource object in it) and then we crash before the ChannelManager gets persisted, we'll fail to generate a PaymentPathFailed when the HTLC is resolved as there won't be an entry in pending_outbound_payments. We should generate some kind of PaymentPathFailed event here, maybe with all_paths_failed set to false, implying more of "dunno" than "full payment not yet failed", which I think a retryer could handle properly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions