Skip to content

remove_channel_in_nodes (and channel_failed with !is_permanent) don't update lowest_inbound_channel_fees #1686

Open
@TheBlueMatt

Description

@TheBlueMatt

While both of these shouldn't cause incorrect routing behavior, they may result in the lowest_inboud_channel_fees value being spuriously high, which could cause slower than optimal routing.

I don't think the right solution here is to just fix the behavior in question, though, I think we really should revisit the lowest_inbound_channel_fees behavior entirely - when I last benchmarked the difference between A* and dijkstra's performance on our router A* was a good bit faster, but our router has changed a lot since then, and I think there's a good chance A* isn't faster anymore (it does imply an extra map lookup during routing!). Before we yank it out entirely, though, I think we should look into storing the lowest_inbound_channel_fees field in the per-channel data as well, avoiding the extra map lookup, which may leave A* a lot faster still.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions