Closed
Description
To improve the deserialization time of our network graph and address #960, we swapped the PublicKey
s describing node ids directly in the graph with a new NodeId
struct in #1107. This improved performance greatly, but missed that we're still deserializing PublicKey
s a ton when reading a NetworkGraph
- we store the original gossip messages in the graph itself with PublicKey
s and have to do a bunch of key checking when reading the graph again.
Replacing the PublicKey
s in gossip messages with NodeId
s should give us yet again a huge speedup in the time it takes to read our network grpah.