`background-processor` `futures` tests leave dangling test directories

[valentinewallace]

Running cargo test --features=futures results in some leftover test directories from async background processor testing that should be deleted at the end of the test, via the Drop implementation for Node. It looks like drop is called, so not sure what's going on here.

[wpaulino]

Whenever we fix this, we might as well update the tests to use temporary directories with something like https://doc.rust-lang.org/std/env/fn.temp_dir.html.

[dunxen]

Yeah, also noticed this. I'm also changing them to use temp_dir() as it was bugging me lol

[TheBlueMatt]

Is there anything left to do here? Do we know in which case(es) this is possible, or is it believe to not be?

[dunxen]

Is there anything left to do here? Do we know in which case(es) this is possible, or is it believe to not be?

Only happens in the async cases. I was still trying to figure out the culprit but the PR makes sure it's not going to leave the working directory dirty at least. Only that the two directories for the async test still stay behind in /tmp.

So up to you if that's ok or I should look a little further.

[TheBlueMatt]

We should definitely clean up even /tmp if possible, it just wasn't clear to me from the above discussion whether there were any known cases were left folders lying around.

[valentinewallace]

It's also always been the case that if you control+C while background processor tests are running, test directories will not be cleaned up. Not sure if that's solvable without moving to mock-persisting rather than actually writing to disk (which seems ok, though actually writing to disk helped us catch several Windowz bugs in the past).

[TheBlueMatt]

In theory we could catch the signal and clean up but killing the tests I'm not as worried about cleaning up. Using a proper temp directory at least improves that.