Skip to content

2077 Followups #2360

Closed
Closed
@dunxen

Description

@dunxen

There are a bunch of followups to #2077 that need to be included before 116.

See: #2077 (review)

Reproduced below:

  • close_channel_internal should fallback to force-closure if the channel is in the inbound/outbound sets, though I'm not sure its super critical,
  • update_partial_channel_config should probably be updated to work on any channel
  • internal_shutdown should FC any pending channels
  • do_chain_event needs to call best_block_updated even on unfunded channels so we time out channels if they aren't funded in 2 weeks
  • peer_connected tries to remove outbound unfunded channels on reconnect but doesn't look at the new outbound map (which, now that I look at it, should be generating a ChannelClosed event, but isn't...ugh we need to consolidate the channel close codepaths)
  • Rename get_funding_outbound_created to get_funding_created

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions