Skip to content

Remove symbolic link to a file out side the crate #2377

Closed as not planned
Closed as not planned
@yanganto

Description

@yanganto

Hi there,

When building with lighting in nix, There is an issue with lightning-invoice

The symbolic link in lightning-invoice points to a file under lightning, which is not under lightning-invoice.
https://github.com/lightningdevkit/rust-lightning/blob/main/lightning-invoice/src/time_utils.rs

Could we change to time_utils as a crate, and both lightning and lightning-invoice explicitly import it in Cargo.toml.

time_utils = {path = "../time_utils"}

If this looks good from your end, I can open a PR on this. Thanks. 🙏

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions