Skip to content

(Minor) Compiler warnings on rust >=1.66 (const_err lint) #2455

Closed
@optout21

Description

@optout21

On Rust toolchain v >= 1.66, 3 compiler warnings are generated, due to usage of #[deny(const_err)], which has been removed, and converted to a hard error.

To fix:

  • Remove these lines, relying on the fact that CI has builds with newer compiler version, so any eventual mis-use will be detected
    or
  • Wrap these lines in conditional compilation (e.g. #[rustversion::before(1.66)]), so that it's active only on older versions. However, making a directive conditional may not be trivial.
warning: lint `const_err` has been removed: converted into hard error, see issue #71800 <https://github.com/rust-lang/rust/issues/71800> for more information
    --> lightning/src/ln/channelmanager.rs:1253:8
     |
1253 | #[deny(const_err)]
     |        ^^^^^^^^^
     |
     = note: `#[warn(renamed_and_removed_lints)]` on by default

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions