Skip to content

Update Event::PaymentReceived docs since we require payment secret #1079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

TheBlueMatt
Copy link
Collaborator

Users no longer need to verify the amounts of received payments as
the payment secret will protect us against the probing attacks such
verification was intended to fix.

Reported at getlipa/ldk-sample-java#1 (comment)

@codecov
Copy link

codecov bot commented Sep 17, 2021

Codecov Report

Merging #1079 (d7d7801) into main (088daf7) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head d7d7801 differs from pull request most recent head 7478207. Consider uploading reports for the commit 7478207 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1079      +/-   ##
==========================================
- Coverage   91.01%   90.99%   -0.02%     
==========================================
  Files          65       65              
  Lines       33767    33767              
==========================================
- Hits        30732    30727       -5     
- Misses       3035     3040       +5     
Impacted Files Coverage Δ
lightning/src/util/events.rs 27.54% <ø> (ø)
lightning/src/ln/functional_tests.rs 97.42% <0.00%> (-0.09%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 088daf7...7478207. Read the comment docs.

Users no longer need to verify the amounts of received payments as
the payment secret will protect us against the probing attacks such
verification was intended to fix.
@TheBlueMatt
Copy link
Collaborator Author

Squashed without change, will land after CI:

$ git diff-tree -U1 d7d78012 7478207d
$

@TheBlueMatt TheBlueMatt merged commit ab0739e into lightningdevkit:main Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants