Move pending payment tracking to after the new HTLC flies #1109
Conversation
TheBlueMatt
force-pushed
the
2021-10-init-fail-payment-retry-leak
branch
from
2de839e to
34e2ad5
Compare
|
Caught another super minor issue and pushed a trivial fix, also fixed build on older rustc. |
Codecov Report
@@ Coverage Diff @@
## main #1109 +/- ##
==========================================
- Coverage 90.68% 90.50% -0.19%
==========================================
Files 65 66 +1
Lines 34587 34707 +120
==========================================
+ Hits 31365 31410 +45
- Misses 3222 3297 +75
Continue to review full report at Codecov.
|
lightning/src/ln/payment_tests.rs
Outdated
| } | ||
|
|
||
| #[test] | ||
| fn retry_on_init_fail() { |
There was a problem hiding this comment.
Test name doesn't seem to reflect what's happening in the test. How about expanding the test to reconnect the nodes and successfully send another payment? Then add another check showing the payment is being tracked. Could name the test tracks_pending_outbound_payment.
There was a problem hiding this comment.
I just renamed it no_pending_leak_on_initial_send_failure, I'm not sure what reconnecting and sending does - the point is that you can't retry at that point, not sending a full payment.
TheBlueMatt
force-pushed
the
2021-10-init-fail-payment-retry-leak
branch
from
34e2ad5 to
f8b89a1
Compare
If we attempt to send a payment, but the HTLC cannot be send due to local channel limits, we'll provide the user an error but end up with an entry in our pending payment map. This will result in a memory leak as we'll never reclaim the pending payment map entry.
TheBlueMatt
force-pushed
the
2021-10-init-fail-payment-retry-leak
branch
from
f8b89a1 to
a58c617
Compare
|
Squashed without changes, will land after CI: |
If we attempt to send a payment, but the HTLC cannot be send due to
local channel limits, we'll provide the user an error but end up
with an entry in our pending payment map. This will result in a
memory leak as we'll never reclaim the pending payment map entry.