0.0.104 bindings #1219
Merged
0.0.104 bindings #1219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkczyz
reviewed
Dec 18, 2021
Merged
TheBlueMatt
force-pushed
the
2021-12-0.0.104-bindings
branch
from
7f5122b to
95630be
Compare
|
Rebased on #1218 |
...as otherwise the struct is rather useless.
The bindings generation really should support generic bounds other than Deref::Target in where clauses, but currently does not. To avoid needing to add support during the current release process, we simply swap around the arguments to move them to the first <> instead of the where.
We don't really care about more than this in bindings - calling into a custom `Score` is likely too slow to be practical anyway, so this is also a performance improvement. Works around rust-lang/rust#90448
TheBlueMatt
force-pushed
the
2021-12-0.0.104-bindings
branch
from
95630be to
731fa9d
Compare
jkczyz
approved these changes
Dec 19, 2021
arik-so
approved these changes
Dec 19, 2021
|
CI Failures are just cause we need the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two commits from #1218 and one rebased (but much smaller now) from 0.0.103-bindings.