Improve KeysInterface::sign_invoice API #1272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devrandom
force-pushed
the
2022-01-sign-invoice-api
branch
2 times, most recently
from
5884cce to
8d0b48e
Compare
TheBlueMatt
previously approved these changes
Jan 21, 2022
split hrp from invoice data, to allow parsing, since there is no delimiter between the two parts
devrandom
force-pushed
the
2022-01-sign-invoice-api
branch
from
8d0b48e to
803d6b6
Compare
|
unrelated error. should probably disable rust self-update (?!) checks, although I'm not sure how. |
|
Github Action isn't...the most reliable platform ever.
|
TheBlueMatt
approved these changes
Jan 24, 2022
valentinewallace
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split hrp from invoice data, to allow parsing, since there is no delimiter between the two parts in the flat preimage.