Router benchmark improvements #1275
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor generate_routes and generate_mpp_routes into a single utility for benchmarking. The utility is parameterized with features in order to test both single path and multi-path routing. Additionally, it is parameterized with a Score to be used with other scorers.
Passing first_hops to get_route increases the coverage of the benchmark test. For scorers needing the sending node, it allows for using a single scorer in the benchmark rather than re-initializing on each iteration. As a consequence, the scorer can be seeded with success and failure data.
Scorers may have different performance characteristics after seeing failed and successful paths. Seed the scorer with some random data before executing the benchmark in order to exercise such behavior.
jkczyz
force-pushed
the
2022-01-benchmark-improvements
branch
from
ba8d084 to
d924c5d
Compare
Codecov Report
@@ Coverage Diff @@
## main #1275 +/- ##
=======================================
Coverage 90.38% 90.39%
=======================================
Files 71 71
Lines 38135 38135
=======================================
+ Hits 34470 34471 +1
+ Misses 3665 3664 -1
Continue to review full report at Codecov.
|
TheBlueMatt
approved these changes
Jan 25, 2022
valentinewallace
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
generate_routesandgenerate_mpp_routesbenchmarks in order to:Scoreimplementationfirst_hopsparameterAdds a benchmark for a zero-penalty scorer to establish a baseline.
Broken out from #1227.