Avoid overflow in addition when checking counterparty feerates #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is harmless outside of debug builds - the feerate will overflow causing it to either spuriously fail the first check, or correctly pass it and fail the second check. In debug builds, however, it panics due to integer overflow. Found by the `full_stack_target` fuzz test in the Chaincode-provided continuous fuzzing. Thanks Chaincode!
Codecov Report
@@ Coverage Diff @@
## main #1282 +/- ##
==========================================
+ Coverage 90.40% 90.91% +0.51%
==========================================
Files 71 71
Lines 38135 39876 +1741
==========================================
+ Hits 34476 36254 +1778
+ Misses 3659 3622 -37
Continue to review full report at Codecov.
|
jkczyz
approved these changes
Jan 26, 2022
valentinewallace
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is harmless outside of debug builds - the feerate will
overflow causing it to either spuriously fail the first check, or
correctly pass it and fail the second check. In debug builds,
however, it panics due to integer overflow.
Found by the
full_stack_targetfuzz test in theChaincode-provided continuous fuzzing. Thanks Chaincode!