Correct handling of UnknownRequiredFeature deserialization
#1283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quite some time ago, `UnknownRequiredFeature` was only used when a gossip message has a missing required feature. These days, its also used for any required TLV which we do not understand in any message. However, the handling of it was never updated in `PeerManager`, leaving it printing a warning about gossip and ignoring the message entirely. Instead, we send a warning message and disconnect. Closes lightningdevkit#1236, as caught by @jkczyz.
jkczyz
approved these changes
Jan 26, 2022
valentinewallace
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite some time ago,
UnknownRequiredFeaturewas only used when agossip message has a missing required feature. These days, its also
used for any required TLV which we do not understand in any
message. However, the handling of it was never updated in
PeerManager, leaving it printing a warning about gossip andignoring the message entirely.
Instead, we send a warning message and disconnect.
Closes #1236, as caught by @jkczyz.