Work around rustc bug on nightly and make benchmarks not run test code #1301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently rustc doesn't (actually) provide any kind of compilation-stability guarantees, despite their claims. Here we work around rustc being unstable by making the trait call explicit. See also rust-lang/rust#93599
`cargo bench` sets `cfg(test)`, causing us to hit some test-only code in the router when benchmarking, throwing off our benchmarks substantially. Here we swap from the `unstable` feature to a more clearly internal feature (`_bench_unstable`) and also checking for it when enabling test-only code.
TheBlueMatt
force-pushed
the
2022-02-router-no-test
branch
from
fe92120 to
c8e3078
Compare
jkczyz
reviewed
Feb 11, 2022
| @@ -24,7 +24,7 @@ max_level_trace = [] | |||
| # Allow signing of local transactions that may have been revoked or will be revoked, for functional testing (e.g. justice tx handling). | |||
| # This is unsafe to use in production because it may result in the counterparty publishing taking our funds. | |||
| unsafe_revoked_tx_signing = [] | |||
| unstable = [] | |||
| _bench_unstable = [] | |||
There was a problem hiding this comment.
Maybe just call this _bench? Presumably we'd still want this when no longer unstable.
There was a problem hiding this comment.
Well the only reason we have a feature is because its unstable. If cargo bench weren't unstable we'd remove the feature entirely (though there's some indication cargo bench will never be stabilized).
jkczyz
approved these changes
Feb 14, 2022
arik-so
approved these changes
Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.