Skip to content

Bump MSRV to 1.41.1. #1310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Conversation

TheBlueMatt
Copy link
Collaborator

1.41.1 is currently the Firefox ESR MSRV, which means its also the
version several Linux distros ship. Further, rust-bitcoin is likely
to make a similar change soon, see
rust-bitcoin/rust-bitcoin#510.

Lets wait until 106 for this.

1.41.1 is currently the Firefox ESR MSRV, which means its also the
version several Linux distros ship. Further, rust-bitcoin is likely
to make a similar change soon, see
rust-bitcoin/rust-bitcoin#510.
@codecov-commenter
Copy link

codecov-commenter commented Feb 15, 2022

Codecov Report

Merging #1310 (9f277dc) into main (963f8d9) will increase coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1310      +/-   ##
==========================================
+ Coverage   90.51%   90.90%   +0.39%     
==========================================
  Files          71       72       +1     
  Lines       39210    41970    +2760     
==========================================
+ Hits        35490    38154    +2664     
- Misses       3720     3816      +96     
Impacted Files Coverage Δ
lightning/src/util/scid_utils.rs 98.58% <0.00%> (-1.42%) ⬇️
lightning/src/ln/functional_tests.rs 97.07% <0.00%> (-0.04%) ⬇️
lightning/src/util/crypto.rs 100.00% <0.00%> (ø)
lightning/src/routing/router.rs 91.92% <0.00%> (+0.12%) ⬆️
lightning-invoice/src/de.rs 81.27% <0.00%> (+0.20%) ⬆️
lightning/src/chain/keysinterface.rs 96.15% <0.00%> (+0.29%) ⬆️
lightning/src/ln/onion_utils.rs 96.05% <0.00%> (+0.41%) ⬆️
lightning-invoice/src/lib.rs 88.24% <0.00%> (+0.82%) ⬆️
lightning/src/util/test_utils.rs 83.78% <0.00%> (+1.52%) ⬆️
lightning/src/ln/functional_test_utils.rs 97.27% <0.00%> (+2.04%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 963f8d9...9f277dc. Read the comment docs.

@jkczyz jkczyz self-requested a review February 15, 2022 23:53
@valentinewallace
Copy link
Contributor

CI seems confused 🤔 it's waiting on checks from the deprecated-as-of-this-PR Rust versions. I'm guessing it'd go away after merge but just wanted to note.

@TheBlueMatt TheBlueMatt added this to the 0.0.106 milestone Feb 16, 2022
@TheBlueMatt
Copy link
Collaborator Author

CI seems confused thinking it's waiting on checks from the deprecated-as-of-this-PR Rust versions. I'm guessing it'd go away after merge but just wanted to note.

Oh, thanks, yea, will have to disable those checks as "required" in the repo config.

@TheBlueMatt TheBlueMatt merged commit 5e86bbf into lightningdevkit:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants