Skip to content

Drop fuzztarget feature entirely #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 18, 2022

Conversation

TheBlueMatt
Copy link
Collaborator

Some time ago we started transitioning to cfg(fuzzing) instead of
exposing a full feature. Here we complete the transition.

@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2022

Codecov Report

Merging #1316 (d7bb532) into main (8e7f241) will increase coverage by 0.14%.
The diff coverage is 100.00%.

❗ Current head d7bb532 differs from pull request most recent head b0cb558. Consider uploading reports for the commit b0cb558 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1316      +/-   ##
==========================================
+ Coverage   90.52%   90.66%   +0.14%     
==========================================
  Files          72       72              
  Lines       39560    40288     +728     
==========================================
+ Hits        35811    36527     +716     
- Misses       3749     3761      +12     
Impacted Files Coverage Δ
lightning/src/chain/chainmonitor.rs 97.64% <ø> (ø)
lightning/src/lib.rs 100.00% <ø> (ø)
lightning/src/ln/chan_utils.rs 95.51% <ø> (ø)
lightning/src/ln/channel.rs 89.33% <ø> (ø)
lightning/src/ln/mod.rs 95.00% <ø> (ø)
lightning/src/ln/msgs.rs 85.88% <ø> (ø)
lightning/src/routing/router.rs 91.92% <ø> (ø)
lightning/src/util/chacha20.rs 96.37% <ø> (ø)
lightning/src/util/chacha20poly1305rfc.rs 97.95% <ø> (ø)
lightning/src/util/fuzz_wrappers.rs 100.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e7f241...b0cb558. Read the comment docs.

@TheBlueMatt TheBlueMatt force-pushed the 2022-02-no-fuzztarget branch from ec54fee to df28c3a Compare February 17, 2022 20:27
@TheBlueMatt TheBlueMatt force-pushed the 2022-02-no-fuzztarget branch from df28c3a to d7bb532 Compare February 18, 2022 15:55
Some time ago we started transitioning to `cfg(fuzzing)` instead of
exposing a full feature. Here we complete the transition.
@TheBlueMatt TheBlueMatt force-pushed the 2022-02-no-fuzztarget branch from d7bb532 to b0cb558 Compare February 18, 2022 17:03
@TheBlueMatt TheBlueMatt merged commit 7ac4c3b into lightningdevkit:main Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants