Reduce the number of timer ticks a peer is allowed to take #1348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 2d3a210, we increased the default ping timer in `lightning-background-processor` to ten seconds from five. However, we didn't change the timer count at which we disconnect peers if they're not responding, which we likely should have done. We do so here, as well as update the documentation for `PeerManager::timer_tick_occurred` to suggest always ticking the timer every ten seconds instead of five.
Codecov Report
@@ Coverage Diff @@
## main #1348 +/- ##
=======================================
Coverage 90.57% 90.57%
=======================================
Files 72 72
Lines 40082 40082
=======================================
Hits 36306 36306
Misses 3776 3776
Continue to review full report at Codecov.
|
jkczyz
approved these changes
Mar 9, 2022
arik-so
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 2d3a210, we increased the
default ping timer in
lightning-background-processorto tenseconds from five. However, we didn't change the timer count at
which we disconnect peers if they're not responding, which we
likely should have done. We do so here, as well as update the
documentation for
PeerManager::timer_tick_occurredto suggestalways ticking the timer every ten seconds instead of five.