Skip to content

Correctly verify and forward excess data post-signature in signed announcement messages #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

TheBlueMatt
Copy link
Collaborator

Title plus a few other things for BOLT 7 compliance. See commit messages for more info.

@TheBlueMatt
Copy link
Collaborator Author

This is gonna have to inform the design of #119, so I'm gonna go ahead and take this.

@TheBlueMatt TheBlueMatt merged commit a1aaea5 into lightningdevkit:master Aug 29, 2018
@yuntai
Copy link
Contributor

yuntai commented Aug 31, 2018

Can we assume underlying Read can raise EOF at the end of the message (including excess data), so we can loop until EOF to collect data for hashing?

@TheBlueMatt
Copy link
Collaborator Author

TheBlueMatt commented Aug 31, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants