Skip to content

Log as channel liquidities are/not updated in ProbabilisticScorer #1405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

TheBlueMatt
Copy link
Collaborator

Does what it says on the tin. Not a whole lot more, getting visibility into the liquidities assigned in the scorer may be useful to debug stuff in the field if anything goes wrong.

@TheBlueMatt
Copy link
Collaborator Author

I ran into ElementsProject/lightning#5154 which caused me to keep retrying a payment across the same first hop over and over again, as we were trusting our own local state over any scoring data. I still think this is the correct behavior - ultimately my immediate peer is exhibiting a bug and I should close the channel, but the logging was substantially lacking, which is improved here.

@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2022

Codecov Report

Merging #1405 (a6ae7ca) into main (03f6550) will decrease coverage by 0.00%.
The diff coverage is 88.88%.

❗ Current head a6ae7ca differs from pull request most recent head 6e298ff. Consider uploading reports for the commit 6e298ff to get more accurate results

@@            Coverage Diff             @@
##             main    #1405      +/-   ##
==========================================
- Coverage   90.84%   90.83%   -0.01%     
==========================================
  Files          74       74              
  Lines       41288    41326      +38     
  Branches    41288    41326      +38     
==========================================
+ Hits        37507    37539      +32     
- Misses       3781     3787       +6     
Impacted Files Coverage Δ
lightning/src/routing/router.rs 92.42% <0.00%> (-0.08%) ⬇️
lightning/src/routing/scoring.rs 94.36% <96.82%> (-0.01%) ⬇️
lightning/src/ln/onion_utils.rs 95.34% <100.00%> (+0.01%) ⬆️
lightning/src/ln/functional_tests.rs 97.11% <0.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f6550...6e298ff. Read the comment docs.

@TheBlueMatt
Copy link
Collaborator Author

Rebased.

@TheBlueMatt TheBlueMatt force-pushed the 2022-04-log-scoring branch 2 times, most recently from a6ae7ca to 549bec1 Compare April 15, 2022 17:05
@TheBlueMatt TheBlueMatt force-pushed the 2022-04-log-scoring branch from 549bec1 to c3d6155 Compare April 15, 2022 17:07
@TheBlueMatt
Copy link
Collaborator Author

CC lightning/bolts#979

Copy link
Contributor

@valentinewallace valentinewallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@TheBlueMatt
Copy link
Collaborator Author

Dropped the log commit as we should actually fix it per #1450 instead of just changing logging.

@valentinewallace valentinewallace merged commit df1c4ee into lightningdevkit:main Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants