-
Notifications
You must be signed in to change notification settings - Fork 407
Log as channel liquidities are/not updated in ProbabilisticScorer #1405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log as channel liquidities are/not updated in ProbabilisticScorer #1405
Conversation
I ran into ElementsProject/lightning#5154 which caused me to keep retrying a payment across the same first hop over and over again, as we were trusting our own local state over any scoring data. I still think this is the correct behavior - ultimately my immediate peer is exhibiting a bug and I should close the channel, but the logging was substantially lacking, which is improved here. |
Codecov Report
@@ Coverage Diff @@
## main #1405 +/- ##
==========================================
- Coverage 90.84% 90.83% -0.01%
==========================================
Files 74 74
Lines 41288 41326 +38
Branches 41288 41326 +38
==========================================
+ Hits 37507 37539 +32
- Misses 3781 3787 +6
Continue to review full report at Codecov.
|
dc6569d
to
2853af2
Compare
2853af2
to
9841a92
Compare
Rebased. |
a6ae7ca
to
549bec1
Compare
549bec1
to
c3d6155
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
6e298ff
c3d6155
to
6e298ff
Compare
Dropped the log commit as we should actually fix it per #1450 instead of just changing logging. |
Does what it says on the tin. Not a whole lot more, getting visibility into the liquidities assigned in the scorer may be useful to debug stuff in the field if anything goes wrong.