Move lightning-invoice deser errors to lib.rs instead of pub use
#1409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1409 +/- ##
==========================================
- Coverage 90.83% 90.82% -0.02%
==========================================
Files 73 73
Lines 41266 41266
Branches 41266 41266
==========================================
- Hits 37486 37479 -7
- Misses 3780 3787 +7
Continue to review full report at Codecov.
|
arik-so
previously approved these changes
Apr 4, 2022
Having public types in a private module is somewhat awkward from a readability standpoint, but, more importantly, the bindings logic has a relatively rough go of converting them - it doesn't implement `pub use` as its "implement this function" logic is all within the context of a module. We'd need to keep a set of re-exported things to implement them when parsing modules...or we could just move two enums from `de.rs` to `lib.rs` here, which is substantially less work.
TheBlueMatt
force-pushed
the
2022-04-bindings-invoice-ders
branch
from
03cafce to
ce5a9f5
Compare
|
Oops, sorry, dropped a spurious newline I'd added. |
jkczyz
approved these changes
Apr 4, 2022
arik-so
approved these changes
Apr 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having public types in a private module is somewhat awkward from a
readability standpoint, but, more importantly, the bindings logic
has a relatively rough go of converting them - it doesn't implement
pub useas its "implement this function" logic is all within thecontext of a module. We'd need to keep a set of re-exported things
to implement them when parsing modules...or we could just move two
enums from
de.rstolib.rshere, which is substantially lesswork.
If we're happy with this I'll open a copy of this against
0.0.106-bindings.