Add documentation for creating new fuzz test targets. #1467
+44
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
reviewed
May 5, 2022
| ## How do I add a new fuzz test? | ||
|
|
||
| 1. The easiest approach is to take one of the files in `fuzz/src/`, such as e. g. | ||
| `process_network_graph.rs`, and duplicate it, renaming the new file to something more |
There was a problem hiding this comment.
nit: this doesnt exist quite yet :)
There was a problem hiding this comment.
Did we wanna resolve this @arik-so?
There was a problem hiding this comment.
nope. I wanna land the graph sync PR 😛
Codecov Report
@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 90.91% 90.90% -0.02%
==========================================
Files 75 75
Lines 41826 41826
Branches 41826 41826
==========================================
- Hits 38028 38022 -6
- Misses 3798 3804 +6
Continue to review full report at Codecov.
|
arik-so
force-pushed
the
fuzz_new_target_docs
branch
from
790d54b to
ec0436b
Compare
dunxen
reviewed
May 5, 2022
fuzz/README.md
Outdated
|
|
||
| ## How do I add a new fuzz test? | ||
|
|
||
| 1. The easiest approach is to take one of the files in `fuzz/src/`, such as e. g. |
There was a problem hiding this comment.
Suggested change
| 1. The easiest approach is to take one of the files in `fuzz/src/`, such as e. g. | |
| 1. The easiest approach is to take one of the files in `fuzz/src/`, for example, |
Think this reads a bit better :)
There was a problem hiding this comment.
I think just "such as" reads the nicest, so I removed "e. g."
arik-so
force-pushed
the
fuzz_new_target_docs
branch
from
ec0436b to
2d42bfc
Compare
arik-so
force-pushed
the
fuzz_new_target_docs
branch
from
2d42bfc to
5c64eec
Compare
TheBlueMatt
approved these changes
May 6, 2022
dunxen
approved these changes
May 6, 2022
vincenzopalazzo
approved these changes
May 9, 2022
valentinewallace
approved these changes
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.