-
Notifications
You must be signed in to change notification settings - Fork 412
Add documentation for creating new fuzz test targets. #1467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for creating new fuzz test targets. #1467
Conversation
## How do I add a new fuzz test? | ||
|
||
1. The easiest approach is to take one of the files in `fuzz/src/`, such as e. g. | ||
`process_network_graph.rs`, and duplicate it, renaming the new file to something more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: this doesnt exist quite yet :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did we wanna resolve this @arik-so?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope. I wanna land the graph sync PR 😛
Codecov Report
@@ Coverage Diff @@
## main #1467 +/- ##
==========================================
- Coverage 90.91% 90.90% -0.02%
==========================================
Files 75 75
Lines 41826 41826
Branches 41826 41826
==========================================
- Hits 38028 38022 -6
- Misses 3798 3804 +6
Continue to review full report at Codecov.
|
790d54b
to
ec0436b
Compare
fuzz/README.md
Outdated
|
||
## How do I add a new fuzz test? | ||
|
||
1. The easiest approach is to take one of the files in `fuzz/src/`, such as e. g. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1. The easiest approach is to take one of the files in `fuzz/src/`, such as e. g. | |
1. The easiest approach is to take one of the files in `fuzz/src/`, for example, |
Think this reads a bit better :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think just "such as" reads the nicest, so I removed "e. g."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool, works too!
ec0436b
to
2d42bfc
Compare
2d42bfc
to
5c64eec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good mod Matt's feedback. Nice to get more fuzzing docs
No description provided.