Skip to content

Mention backwards compatibility in CONTRIBUTING. #1501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tnull
Copy link
Contributor

@tnull tnull commented May 27, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 28, 2022

Codecov Report

Merging #1501 (cefac72) into main (1fd6c6f) will increase coverage by 0.48%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1501      +/-   ##
==========================================
+ Coverage   90.96%   91.45%   +0.48%     
==========================================
  Files          80       80              
  Lines       42808    47766    +4958     
  Branches    42808    47766    +4958     
==========================================
+ Hits        38942    43684    +4742     
- Misses       3866     4082     +216     
Impacted Files Coverage Δ
lightning/src/util/events.rs 32.43% <0.00%> (-1.13%) ⬇️
lightning/src/chain/onchaintx.rs 93.98% <0.00%> (-0.93%) ⬇️
lightning/src/ln/priv_short_conf_tests.rs 97.09% <0.00%> (-0.87%) ⬇️
lightning/src/util/scid_utils.rs 98.75% <0.00%> (-0.45%) ⬇️
lightning-net-tokio/src/lib.rs 75.91% <0.00%> (-0.31%) ⬇️
lightning/src/ln/functional_tests.rs 97.18% <0.00%> (-0.01%) ⬇️
lightning/src/util/config.rs 44.21% <0.00%> (+0.21%) ⬆️
lightning/src/routing/router.rs 94.07% <0.00%> (+1.62%) ⬆️
lightning/src/ln/functional_test_utils.rs 97.67% <0.00%> (+2.22%) ⬆️
lightning/src/ln/channel.rs 91.70% <0.00%> (+3.09%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fd6c6f...cefac72. Read the comment docs.

@tnull tnull force-pushed the 2022-05-mention-compat-level branch from 7218627 to cefac72 Compare May 28, 2022 00:18
Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK cefac72

@TheBlueMatt TheBlueMatt merged commit 8e5cf75 into lightningdevkit:main Jun 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants