Skip to content

Have find_route take a NetworkGraph instead of a ReadOnly one #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

TheBlueMatt
Copy link
Collaborator

Because downstream languages are often garbage-collected, having
the user directly allocate a ReadOnlyNetworkGraph and pass a
reference to it to find_route often results in holding a read
lock long in excess of the find_route call. Worse, some languages
(like JavaScript) tend to only garbage collect when other code is
not running, possibly leading to deadlocks.

Note that I'm gonna take this in the 0.0.108 bindings in Java

Because downstream languages are often garbage-collected, having
the user directly allocate a `ReadOnlyNetworkGraph` and pass a
reference to it to `find_route` often results in holding a read
lock long in excess of the `find_route` call. Worse, some languages
(like JavaScript) tend to only garbage collect when other code is
not running, possibly leading to deadlocks.
@TheBlueMatt TheBlueMatt added this to the 0.0.109 milestone Jun 29, 2022
Copy link
Contributor

@dunxen dunxen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 87a6e01

@TheBlueMatt TheBlueMatt merged commit 8a97e58 into lightningdevkit:main Jun 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants