Skip to content

Fix 'not a hyperlink' doc warning #1624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

tnull
Copy link
Contributor

@tnull tnull commented Jul 20, 2022

Fixes the following warning during cargo doc:

warning: this URL is not a hyperlink
  --> lightning/src/chain/chaininterface.rs:67:5
   |
67 | /// https://github.com/ElementsProject/lightning/commit/2e687b9b352c9092b5e8bd4a688916ac50b44af0
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use an automatic link instead: `<https://github.com/ElementsProject/lightning/commit/2e687b9b352c9092b5e8bd4a688916ac50b44af0>`
   |
   = note: `#[warn(rustdoc::bare_urls)]` on by default
   = note: bare URLs are not automatically turned into clickable links

@codecov-commenter
Copy link

codecov-commenter commented Jul 20, 2022

Codecov Report

Merging #1624 (97e6682) into main (5023ff0) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1624      +/-   ##
==========================================
- Coverage   90.82%   90.79%   -0.03%     
==========================================
  Files          80       80              
  Lines       44643    44643              
  Branches    44643    44643              
==========================================
- Hits        40547    40535      -12     
- Misses       4096     4108      +12     
Impacted Files Coverage Δ
lightning/src/chain/chaininterface.rs 96.15% <ø> (ø)
lightning-net-tokio/src/lib.rs 76.85% <0.00%> (-0.31%) ⬇️
lightning/src/ln/functional_tests.rs 96.94% <0.00%> (-0.17%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5023ff0...97e6682. Read the comment docs.

@TheBlueMatt TheBlueMatt merged commit 661b734 into lightningdevkit:main Jul 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants