Remove Slack and update CONTRIBUTING
#1637
Conversation
|
@jkczyz Is your LDK Dev Meet calendar so official/public that you'd be comfortable having it added to |
Yeah, in the sense that I update it if a meeting is canceled. |
| Anyone is invited to contribute without regard to technical experience, | ||
| "expertise", OSS experience, age, or other concern. However, the development of | ||
| cryptocurrencies demands a high-level of rigor, adversarial thinking, thorough | ||
| testing and risk-minimization. Any bug may cost users real money. That being |
There was a problem hiding this comment.
"risk-minimization engineering process"
There was a problem hiding this comment.
Hm, I don't think adding this checks out? Would read "However, the development of cryptocurrencies demands a high-level of (...) risk-minimization engineering process". So I think the current form is more correct?
There was a problem hiding this comment.
Sure, just risk-minimization doesn't seem to refer what is actually qualified risk-minimized.
| development compared to your merged work. | ||
| This doesn't mean don't be ambitious with the breadth and depth of your | ||
| contributions but rather understand the project culture before investing an | ||
| asymmetric number of hours on development compared to your merged work. |
There was a problem hiding this comment.
"Remember to be patient. While we're lucky to have a number of contributors eager to provide reliable and qualified review time, we're evolving in a FOSS environment, where other people time is never due but a gift".
For context, those lines were inspired from issues we have previous contributors, getting quickly frustrated about the slowness of our review process at that time, and overreacting from our perspective.
There was a problem hiding this comment.
While I see the motivation, I'm hesitant to put such a upfront defensive warning here under 'Getting Started'. Can we maybe continue to handle this on an individual basis if it comes up?
Great, I now added a calendar link. In fact, I added the embedded version, since the other required me to log in to Google. |
|
I assume you can go ahead and squash. |
tnull
force-pushed
the
2022-07-contrib-remove-slack
branch
from
29993c8 to
afdad49
Compare
Squashed! |
Since it came up on Discord, I now also removed Slack and updated
CONTRIBUTING.