Ensure we log private channel_updates at a non-GOSSIP log level #1695
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1695 +/- ##
==========================================
+ Coverage 90.77% 90.85% +0.08%
==========================================
Files 80 85 +5
Lines 44763 46269 +1506
Branches 44763 46269 +1506
==========================================
+ Hits 40632 42037 +1405
- Misses 4131 4232 +101
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tnull
previously approved these changes
Sep 6, 2022
dunxen
previously approved these changes
Sep 6, 2022
If we receive a channel_update for one of our private channels, we will not log the message at the usual TRACE log level as the message falls into the gossip range. However, for our own channels they aren't *just* gossip, as we store that info and it changes how we generate invoices. Thus, we add a log in `ChannelManager` here at the DEBUG log level.
TheBlueMatt
force-pushed
the
2022-08-log-chan_update
branch
from
4ea6b7d to
602cf5c
Compare
tnull
approved these changes
Sep 6, 2022
dunxen
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we receive a channel_update for one of our private channels, we
will not log the message at the usual TRACE log level as the
message falls into the gossip range. However, for our own channels
they aren't just gossip, as we store that info and it changes
how we generate invoices. Thus, we add a log in
ChannelManagerhere at the DEBUG log level.