Skip to content

[0.0.111-bindings] Bindings Branch Rebase + Backports #1730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 23, 2022
Merged

[0.0.111-bindings] Bindings Branch Rebase + Backports #1730

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
23f5605
Move Scorer requirement away from Router trait
jurvis Sep 15, 2022
eebf05a
Swap `Vec<&RouteHop>` parameters for slices
TheBlueMatt Sep 18, 2022
8edc132
Avoid returning a reference to a u64.
TheBlueMatt Sep 18, 2022
4c5a015
Downgrade `hashbrown` to meet MSRV
TheBlueMatt Sep 22, 2022
2cc9a4d
Add a `MutexGuard` wrapper for the bindings-only `LockableScore`
TheBlueMatt Sep 19, 2022
2bcd067
Make `as_directed_to` non-public
TheBlueMatt Mar 1, 2022
5b56ca4
Simplify type aliasing somewhat around times
TheBlueMatt Mar 1, 2022
93db815
Restrict ChannelInfo::as_directed_from visibility
jkczyz Mar 29, 2022
ad8f800
Tag `KVStore` `(C-not exported)` as `Writeable` isn't mapped
TheBlueMatt Jun 26, 2022
30a8d18
Export Onion Message structs in their respective modules
TheBlueMatt Sep 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fuzz/src/onion_message.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ use lightning::ln::script::ShutdownScript;
use lightning::util::enforcing_trait_impls::EnforcingSigner;
use lightning::util::logger::Logger;
use lightning::util::ser::{Readable, Writer};
use lightning::onion_message::OnionMessenger;
use lightning::onion_message::messenger::OnionMessenger;

use utils::test_logger;

Expand Down
4 changes: 2 additions & 2 deletions lightning-background-processor/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1117,8 +1117,8 @@ mod tests {
// Initiate the background processors to watch each node.
let data_dir = nodes[0].persister.get_data_dir();
let persister = Arc::new(Persister::new(data_dir));
let router = DefaultRouter::new(Arc::clone(&nodes[0].network_graph), Arc::clone(&nodes[0].logger), random_seed_bytes);
let invoice_payer = Arc::new(InvoicePayer::new(Arc::clone(&nodes[0].node), router, Arc::clone(&nodes[0].scorer), Arc::clone(&nodes[0].logger), |_: &_| {}, Retry::Attempts(2)));
let router = DefaultRouter::new(Arc::clone(&nodes[0].network_graph), Arc::clone(&nodes[0].logger), random_seed_bytes, Arc::clone(&nodes[0].scorer));
let invoice_payer = Arc::new(InvoicePayer::new(Arc::clone(&nodes[0].node), router, Arc::clone(&nodes[0].logger), |_: &_| {}, Retry::Attempts(2)));
let event_handler = Arc::clone(&invoice_payer);
let bg_processor = BackgroundProcessor::start(persister, event_handler, nodes[0].chain_monitor.clone(), nodes[0].node.clone(), nodes[0].no_gossip_sync(), nodes[0].peer_manager.clone(), nodes[0].logger.clone(), Some(nodes[0].scorer.clone()));
assert!(bg_processor.stop().is_ok());
Expand Down
5 changes: 2 additions & 3 deletions lightning-invoice/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ rustdoc-args = ["--cfg", "docsrs"]

[features]
default = ["std"]
no-std = ["hashbrown", "lightning/no-std", "core2/alloc"]
no-std = ["hashbrown", "lightning/no-std"]
std = ["bitcoin_hashes/std", "num-traits/std", "lightning/std", "bech32/std"]

[dependencies]
Expand All @@ -24,8 +24,7 @@ lightning = { version = "0.0.111", path = "../lightning", default-features = fal
secp256k1 = { version = "0.24.0", default-features = false, features = ["recovery", "alloc"] }
num-traits = { version = "0.2.8", default-features = false }
bitcoin_hashes = { version = "0.11", default-features = false }
hashbrown = { version = "0.11", optional = true }
core2 = { version = "0.3.0", default-features = false, optional = true }
hashbrown = { version = "0.8", optional = true }
serde = { version = "1.0.118", optional = true }

[dev-dependencies]
Expand Down
Loading