Correct the directionality of liquidity non-update messages #1751
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 90.73% // Head: 90.69% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1751 +/- ##
==========================================
- Coverage 90.73% 90.69% -0.04%
==========================================
Files 87 87
Lines 46713 46715 +2
Branches 46713 46715 +2
==========================================
- Hits 42383 42369 -14
- Misses 4330 4346 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tnull
previously approved these changes
Oct 5, 2022
TheBlueMatt
force-pushed
the
2022-10-fix-score-log-direction
branch
from
dea238b to
3e129f3
Compare
tnull
previously approved these changes
Oct 6, 2022
When we log liquidity updates, if we decline to update anything as the new bounds are already within the old bounds, the directionality of the log entries was reversed. While we're at it, we also log the old values.
|
Amended (the commit timestamp) and pushed to make f'ing Actions actually run the job... |
TheBlueMatt
force-pushed
the
2022-10-fix-score-log-direction
branch
from
3e129f3 to
5d0deac
Compare
wpaulino
approved these changes
Oct 6, 2022
tnull
approved these changes
Oct 7, 2022
valentinewallace
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we log liquidity updates, if we decline to update anything as the new bounds are already within the old bounds, the directionality of the log entries was reversed.
While we're at it, we also log the old values.