Drop the subsecond part of timestamps when constructing invoices #1760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an |
We had a user who was confused why an invoice failed to round-trip (i.e. was not `PartialEq` with itself after write/read) when a subsecond creation time was used (e.g. via the `from_system_time` constructor). This commit should address this confusion by dropping subsecond parts in easily-accessible constructors when creating BOLT 11 invoices. Fixes lightningdevkit#1759.
TheBlueMatt
force-pushed
the
2022-10-invoice-builder-round
branch
from
24a0527 to
008da77
Compare
True, but I think overall this still makes sense to "fix" since subsecond times are not representable in BOLT 11 invoices anyway. |
tnull
approved these changes
Oct 7, 2022
dunxen
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had a user who was confused why an invoice failed to round-trip (i.e. was not
PartialEqwith itself after write/read) when a subsecond creation time was used (e.g. via thefrom_system_timeconstructor).This commit should address this confusion by dropping subsecond parts in easily-accessible constructors when creating BOLT 11 invoices.
Fixes #1759.