Add .to_best_block() method to ValidatedBlockHeader

[MaxFangX]

Adds a new method .to_best_block() to ValidatedBlockHeader which returns a BestBlock that nodes can pass into the channel manager during a fresh start, in order to prevent a possible race condition which eventually results in a channel manager panic when a node is started for the first time.

Required for the bugfix in lightningdevkit/ldk-sample#78.

[codecov-commenter]

Codecov Report

Base: 90.86% // Head: 90.77% // Decreases project coverage by -0.08% ⚠️

Coverage data is based on head (a384bb1) compared to base (4ae65e8).
Patch has no changes to coverable lines.

❗ Current head a384bb1 differs from pull request most recent head a9f8b6e. Consider uploading reports for the commit a9f8b6e to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1777      +/-   ##
==========================================
- Coverage   90.86%   90.77%   -0.09%     
==========================================
  Files          86       87       +1     
  Lines       46482    46969     +487     
  Branches    46482    46969     +487     
==========================================
+ Hits        42234    42637     +403     
- Misses       4248     4332      +84     

Impacted Files	Coverage Δ
lightning-block-sync/src/init.rs	90.90% <ø> (-2.66%)	⬇️
lightning-invoice/src/utils.rs	94.85% <0.00%> (-1.92%)	⬇️
lightning-invoice/src/payment.rs	89.85% <0.00%> (-1.02%)	⬇️
lightning/src/ln/chan_utils.rs	94.55% <0.00%> (-0.95%)	⬇️
lightning/src/ln/peer_handler.rs	55.96% <0.00%> (-0.74%)	⬇️
lightning/src/routing/router.rs	91.62% <0.00%> (-0.45%)	⬇️
lightning/src/util/enforcing_trait_impls.rs	89.07% <0.00%> (-0.40%)	⬇️
lightning-block-sync/src/test_utils.rs	93.14% <0.00%> (-0.33%)	⬇️
lightning-net-tokio/src/lib.rs	76.73% <0.00%> (-0.31%)	⬇️
... and 39 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[MaxFangX]

Pushed changes @jkczyz, removed the new init function entirely and replaced it with a new .best_block() method on ValidatedBlockHeader. It's a lot cleaner this way, thanks for the suggestion!

[MaxFangX]

Implemented once again @jkczyz

[jkczyz]

Thanks for putting this together!

[tnull]

LGTM