Skip to content

Deparametrize ChannelManager to infer Signer from its KeysInterface. #1797

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

arik-so
Copy link
Contributor

@arik-so arik-so commented Oct 24, 2022

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 90.72% // Head: 90.71% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (2c5dc3b) compared to base (a257906).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 2c5dc3b differs from pull request most recent head 5b396c6. Consider uploading reports for the commit 5b396c6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1797      +/-   ##
==========================================
- Coverage   90.72%   90.71%   -0.02%     
==========================================
  Files          87       87              
  Lines       47374    47374              
  Branches    47374    47374              
==========================================
- Hits        42979    42974       -5     
- Misses       4395     4400       +5     
Impacted Files Coverage Δ
lightning-background-processor/src/lib.rs 96.23% <ø> (ø)
lightning-block-sync/src/init.rs 90.90% <ø> (ø)
lightning-invoice/src/utils.rs 95.17% <100.00%> (ø)
lightning/src/ln/chanmon_update_fail_tests.rs 97.67% <100.00%> (ø)
lightning/src/ln/channelmanager.rs 85.16% <100.00%> (-0.03%) ⬇️
lightning/src/ln/functional_test_utils.rs 93.44% <100.00%> (ø)
lightning/src/ln/functional_tests.rs 97.02% <100.00%> (-0.05%) ⬇️
lightning/src/ln/onion_route_tests.rs 97.68% <100.00%> (ø)
lightning/src/ln/payment_tests.rs 98.81% <100.00%> (ø)
lightning/src/ln/priv_short_conf_tests.rs 96.66% <100.00%> (ø)
... and 5 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@arik-so arik-so force-pushed the 2022-10-channel-manager-deparameterization branch from 5b396c6 to 22c367b Compare October 25, 2022 17:02
@arik-so arik-so marked this pull request as ready for review October 25, 2022 17:27
Copy link
Collaborator

@TheBlueMatt TheBlueMatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a handful of other places we can remove the sign bound (eg in the background processor, I think), but this stands on its own and that can happen later.

@valentinewallace valentinewallace merged commit 2e343e7 into lightningdevkit:main Oct 26, 2022
@arik-so
Copy link
Contributor Author

arik-so commented Oct 26, 2022

I know, and I saw those places, but figured I'd do them in a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants