Make InvoicePayer's Router Deref
#1960
Conversation
As of HEAD the `ChannelManager` is parametrized by a `Router`, while `InvoicePayer` also owns a `Router`. In order to allow for a single object being reused, we make the `InvoicePayer` side `Deref`.
Codecov ReportBase: 90.72% // Head: 90.72% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1960 +/- ##
==========================================
- Coverage 90.72% 90.72% -0.01%
==========================================
Files 97 97
Lines 50579 50579
Branches 50579 50579
==========================================
- Hits 45888 45887 -1
- Misses 4691 4692 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Fine with me. Up to @valentinewallace if she wants to eat the conflicts on this one or if we want to land #1916 first and then you can stop using InvoicePayer downstream immediately (maybe? or landing that PR quickly as well)
Val also told me that we could just give a dummy |
As of HEAD the
ChannelManageris parametrized by aDerefRouter, whileInvoicePayeralso owns aRouter. In order to allow for a single object being reused, we make theInvoicePayersideDeref.Note that
InvoicePayerwill be removed anyways soon, but this change should make it easier to work off HEAD until then.