Skip to content

derive Debug for ConfirmationTarget #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

MaxFangX
Copy link
Contributor

I found it useful to include a human-readable string for ConfirmationTarget in an error context.

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2023

Codecov Report

Base: 90.68% // Head: 90.71% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (ad4b91d) compared to base (437fa4f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   90.68%   90.71%   +0.03%     
==========================================
  Files          97       97              
  Lines       50577    50577              
  Branches    50577    50577              
==========================================
+ Hits        45866    45883      +17     
+ Misses       4711     4694      -17     
Impacted Files Coverage Δ
lightning/src/chain/chaininterface.rs 95.65% <0.00%> (ø)
lightning/src/ln/peer_channel_encryptor.rs 93.38% <0.00%> (-0.25%) ⬇️
lightning/src/ln/channelmanager.rs 87.13% <0.00%> (+0.02%) ⬆️
lightning/src/ln/monitor_tests.rs 99.56% <0.00%> (+0.10%) ⬆️
lightning/src/ln/functional_tests.rs 97.03% <0.00%> (+0.11%) ⬆️
lightning/src/chain/channelmonitor.rs 91.03% <0.00%> (+0.19%) ⬆️
lightning-net-tokio/src/lib.rs 77.31% <0.00%> (+0.29%) ⬆️
lightning/src/chain/onchaintx.rs 95.39% <0.00%> (+0.83%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@TheBlueMatt TheBlueMatt merged commit 6742bd5 into lightningdevkit:main Jan 17, 2023
@MaxFangX MaxFangX deleted the max/derive-debug branch January 17, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants