Only return previously confirmed Txids from CM's get_relevant_txids()
#1998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of now the `Confirm::get_relevant_txids()` docs state that it won't return any transactions for which we hadn't previously seen a confirmation. To align its functionality a bit more with the docs, at least for `ChannelManager`, we only return values for which we had registered a confirmation block hash before.
tnull
force-pushed
the
2023-01-no-none-in-channel-relevant-txids
branch
from
0b1955c to
aea96cc
Compare
While now `ChannelManager` will only return previously confirmed transactions, we can't ensure the same for `ChainMonitor`, as we need to maintain backwards compatibility with version prior to 0.0.113, at which we started tracking the block hash in `ChannelMonitor`s. We therefore add a note to the docs stating that users need to track confirmations on their own for channels created prior to 0.0.113.
tnull
force-pushed
the
2023-01-no-none-in-channel-relevant-txids
branch
from
aea96cc to
909bae5
Compare
Codecov ReportBase: 90.90% // Head: 90.89% // Decreases project coverage by
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #1998 +/- ##
==========================================
- Coverage 90.90% 90.89% -0.01%
==========================================
Files 99 99
Lines 52570 52570
Branches 52570 52570
==========================================
- Hits 47787 47786 -1
- Misses 4783 4784 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
TheBlueMatt
approved these changes
Feb 1, 2023
dunxen
approved these changes
Feb 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now the
Confirm::get_relevant_txids()docs state that it won't return any transactions for which we hadn't previously seen a confirmation. To align its functionality a bit more with the docs, at least forChannelManager, we only return values for which we had registered a confirmation block hash before.While now
ChannelManagerwill only return previously confirmed transactions, we can't ensure the same forChainMonitor, as we need to maintain backwards compatibility with version prior to 0.0.113, at which we started tracking the block hash inChannelMonitors. We therefore add a note to the docs stating that users need to track confirmations on their own for channels created prior to 0.0.113.