Make fuzz_threaded_connections more robust
#2074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In `fuzz_threaded_connections`, if one thread is being run while another is starved, and the running thread manages to call `timer_tick_ocurred` twice after the starved thread constructs the inbound connection but before it delivers the first bytes, we'll receive an immediate error and `unwrap` it, causing failure. The fix is trivial, simply remove the unwrap and return if we're already disconnected when we do the initial read. While we're here, we also reduce the frequency of the `timer_tick_ocurred` calls to give us a chance to occasionally deliver some additional messages. Fixes lightningdevkit#2073
wpaulino
approved these changes
Mar 4, 2023
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2074 +/- ##
==========================================
- Coverage 87.18% 87.18% -0.01%
==========================================
Files 100 100
Lines 44743 44744 +1
Branches 44743 44744 +1
==========================================
Hits 39008 39008
- Misses 5735 5736 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
dunxen
approved these changes
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
fuzz_threaded_connections, if one thread is being run while another is starved, and the running thread manages to calltimer_tick_ocurredtwice after the starved thread constructs the inbound connection but before it delivers the first bytes, we'll receive an immediate error andunwrapit, causing failure.The fix is trivial, simply remove the unwrap and return if we're already disconnected when we do the initial read.
While we're here, we also reduce the frequency of the
timer_tick_ocurredcalls to give us a chance to occasionally deliver some additional messages.Fixes #2073