-
Notifications
You must be signed in to change notification settings - Fork 407
Added encoding and decoding tests for BigSize #2078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Please squash the commits down into one, otherwise LGTM. |
c13dca9
to
813ce1c
Compare
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2078 +/- ##
=======================================
Coverage 91.14% 91.14%
=======================================
Files 101 101
Lines 48851 48874 +23
Branches 48851 48874 +23
=======================================
+ Hits 44523 44547 +24
+ Misses 4328 4327 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
813ce1c
to
ff53b78
Compare
Apologies for the initial mixup. There was a bit of a confusion. I had accidentally picked some commits in my branch. I have dropped them and It's sorted now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't bother to correct that these match the upstream test case but either way it's fine.
Thank you |
Yes, please address wilmer's feedback. For a simple PR like this feel free to just squash the fixups as you go rather than adding new commits. |
removed unnecessary debugging line using io::Cursor in place of the std one encoding/decoding tests added for BigSize made the code concise encoding/decoding tests added for BigSize
ff53b78
to
c593383
Compare
Fixes #2051
Tests have been added for the test vectors here for both Encoding and Decoding Parts.