Fix channel_reestablish exchanging in case of lost messages #208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the new storage in HTLC state enums to reproduce the various updates in a CommitmentUpdate group which is obviously required to re-send a commitment_update after pending unreceived updates were dropped. Does not yet handle dropped update_fee updates properly.
TheBlueMatt
force-pushed
the
2018-10-reconnect-fixes
branch
from
c65588c to
c52616d
Compare
|
Gonna merge this since it has pretty exhaustive tests (should have done that in the first place....), but review still welcome! |
|
Quick skim over the 2 first commits, thinks good to me, will look on the others tomorrow |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses some new storage in HTLC state enums to reproduce the
various updates in a CommitmentUpdate group which is obviously
required to re-send a commitment_update after pending unreceived
updates were dropped.
Does not yet handle dropped update_fee updates properly.