Skip to content

lightning-transaction-sync: Bump esplora to 0.4 #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

AnthonyRonning
Copy link
Contributor

This bumps esplora to 0.4 for the lightning-transaction-sync crate.

The main reason I would like this is for rust-bitcoin default features to be turned off: bitcoindevkit/rust-esplora-client#39

Here is the version diff, doesn't seem too impactful so there should be no problems: bitcoindevkit/rust-esplora-client@v0.3.0...v0.4.0

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: +0.01 🎉

Comparison is base (09f5e50) 91.28% compared to head (c3fac44) 91.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2150      +/-   ##
==========================================
+ Coverage   91.28%   91.29%   +0.01%     
==========================================
  Files         102      102              
  Lines       49976    49976              
  Branches    49976    49976              
==========================================
+ Hits        45619    45624       +5     
+ Misses       4357     4352       -5     

see 2 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me, although I don't think you really need to bump it since #2132, where we removed the unnecessary restriction on the version. You should just be able to add the dependency on 0.4 to your project.

@valentinewallace valentinewallace merged commit bdb3fb3 into lightningdevkit:main Apr 4, 2023
@AnthonyRonning AnthonyRonning deleted the esplora-0.4 branch April 4, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants