Use NodeAlias type in NodeAnnouncement #2179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheBlueMatt
previously approved these changes
Apr 12, 2023
benthecarman
force-pushed
the
use-node-alias-type
branch
from
434dcaa to
459218a
Compare
TheBlueMatt
previously approved these changes
Apr 12, 2023
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2179 +/- ##
==========================================
- Coverage 91.36% 91.34% -0.02%
==========================================
Files 102 102
Lines 50369 50370 +1
Branches 50369 50370 +1
==========================================
- Hits 46018 46009 -9
- Misses 4351 4361 +10
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
valentinewallace
previously approved these changes
Apr 13, 2023
benthecarman
dismissed stale reviews from valentinewallace and TheBlueMatt
via
f78e6b9
benthecarman
force-pushed
the
use-node-alias-type
branch
from
459218a to
f78e6b9
Compare
TheBlueMatt
approved these changes
Apr 13, 2023
valentinewallace
approved these changes
Apr 13, 2023
dunxen
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make it easier to be able to display this as a string safely as
NodeAliasalready has impled display.