Fix off-by-one finalized transaction locktime #2212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2212 +/- ##
==========================================
+ Coverage 91.53% 91.54% +0.01%
==========================================
Files 104 104
Lines 51332 51553 +221
Branches 51332 51553 +221
==========================================
+ Hits 46985 47195 +210
- Misses 4347 4358 +11
... and 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
arik-so
reviewed
Apr 22, 2023
TheBlueMatt
reviewed
Apr 22, 2023
The `height` argument passed to `OnchainTxHandler::block_disconnected` represents the height being disconnected, and not the current height. Due to the incorrect assumption, we'd generate a claim with a locktime in the future. Ultimately, we shouldn't be generating claims within `block_disconnected`. Rather, we should retry the claim at a later block height, since the bitcoin blockchain does not ever roll back without connecting a new block. Addressing this is left for future work.
In a future commit, we plan to correctly enforce that the spending transaction has a valid locktime relative to the chain for the node broascasting it in `TestBroadcaster::broadcast_transaction` to. We catch up these test node instances to their expected height, such that we do not fail said enforcement.
While these transactions were still valid, we incorrectly assumed that they would propagate with a locktime of `current_height + 1`, when in reality, only those with a locktime strictly lower than the next height in the chain are allowed to enter the mempool.
wpaulino
force-pushed
the
off-by-one-locktime
branch
from
b8ba85b to
97e4344
Compare
arik-so
approved these changes
Apr 22, 2023
TheBlueMatt
approved these changes
Apr 22, 2023
ariard
reviewed
Apr 24, 2023
| @@ -1036,8 +1036,10 @@ impl<ChannelSigner: WriteableEcdsaChannelSigner> OnchainTxHandler<ChannelSigner> | |||
| } | |||
| } | |||
| for ((_package_id, _), ref mut request) in bump_candidates.iter_mut() { | |||
| // `height` is the height being disconnected, so our `current_height` is 1 lower. | |||
There was a problem hiding this comment.
Trying to claim at next block connection works well, until a user calls invalidateblock and break this assumption, I think (though it’s a quite unorthodox uses of the consensus engine).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While these transactions were still valid, we incorrectly assumed that they would propagate with a locktime of
current_height + 1, when in reality, only those with a locktime strictly lower than the next height in the chain are allowed to enter the mempool.Fixes #2181.