Trivial Bindings Updates #2229
Trivial Bindings Updates #2229
Conversation
| /// | ||
| /// This is not exported to bindings users as functions aren't currently mapped. |
There was a problem hiding this comment.
Should this be on the struct? It only can be created from InvoiceBuilder.
There was a problem hiding this comment.
Well once we fix the builders to work in bindings, we should also add a sign that just takes a private key?
| /// | ||
| /// This is not exported to bindings users as functions are not yet mapped. |
Codecov ReportPatch coverage has no change and project coverage change:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2229 +/- ##
==========================================
+ Coverage 91.55% 91.65% +0.09%
==========================================
Files 104 104
Lines 51749 52184 +435
Branches 51749 52184 +435
==========================================
+ Hits 47379 47827 +448
+ Misses 4370 4357 -13
... and 3 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
TheBlueMatt
force-pushed
the
2023-04-115-bindings-upstream-2
branch
from
4c26091 to
53c48c1
Compare
|
Added more no-export tags for the types which conflict with other takes (specifically Invoice and the errors). We should fix that in general so that users can import both Invoice types without confusion in their downstream code. |
| /// | ||
| /// This is not exported to bindings users as its name conflicts with the BOLT 11 ParseError type. |
There was a problem hiding this comment.
Does not exporting this affect using FromStr and TryFrom implementations for Offer?
There was a problem hiding this comment.
Yes, those are not exported as a result.
One missing constructor and some initial no-exports on the BOLT12 code which I'd like to at least expose the workable parts of (which, sadly, isnt much).