Keys Interface Simplification #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I didn't bother to review the ChannelMonitor events generation that closely, but had glanced at it in a previous version and we can fix it up later as we write tests for it. |
TheBlueMatt
force-pushed
the
2018-10-214-redo
branch
2 times, most recently
from
1485453 to
92d9de6
Compare
added 6 commits
October 27, 2018 09:34
Extend KeyStorage with delayed_payment_base_key and per_commitment_point to derive local_delayed private key
Move ChannelKeys into keysinterface for generate a set of it from master_seed and change return type to panic on bogus data
Drop channel_close_key from ChannelKeys
…nnel Drop channel_monitor_claim_key from ChannelKeys
TheBlueMatt
force-pushed
the
2018-10-214-redo
branch
from
92d9de6 to
5180686
Compare
yuntai
reviewed
Oct 27, 2018
| let mut seed = [0; 32]; | ||
| for (arr, slice) in seed.iter_mut().zip((&channel_pubkey.public_key.serialize()[0..32]).iter()) { | ||
| *arr = *slice; | ||
| } |
There was a problem hiding this comment.
simpler with copy_from_slice()?
[0u8; 32] will look better.
Lastly, wouldn't be seed always same for a fixed channel_master_key?
This just missed the merge and after a merge and a comment doesn't seem to trigger a notification so I try @TheBlueMatt
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #214 with some slight changes here and there to simplify things.