Remove unneeded allocation #2262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<E as serde::de::Error>::custom()` accepts any `T: Display`, not just `String`. Therefore it accepts `Arguments<'_>` too so we can use `format_args!()` instead of `format!()`. See lightningdevkit#2187 (comment)
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #2262 +/- ##
==========================================
- Coverage 91.63% 91.61% -0.03%
==========================================
Files 104 104
Lines 51985 51985
Branches 51985 51985
==========================================
- Hits 47638 47627 -11
- Misses 4347 4358 +11
☔ View full report in Codecov by Sentry. |
TheBlueMatt
approved these changes
May 4, 2023
wpaulino
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<E as serde::de::Error>::custom()accepts anyT: Display, not justString. Therefore it acceptsArguments<'_>too so we can useformat_args!()instead offormat!().See #2187 (comment)